Interpreter: Don't link librt and libdl on GNU systems
#12038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glibc 2.34 has merged librt and libdl into libc, so they're not available as shared libraries. The symbols are still available to the interpreter because they are loaded in the compiler.
Blacksmoke16
added
kind:bug
|
2.34 is less than a year old though. Would it make sense to check the glibc version? Dunno if the machinery to do that is available though. |
|
I don't think there is machinery to check glibc's version, I've mostly done what @straight-shoota did previously with #11807 |
straight-shoota
approved these changes
May 7, 2022
straight-shoota
changed the title
librt and libdl on GNU systems
I3oris
added a commit
to I3oris/ic
that referenced
this pull request
Jun 12, 2022
I3oris
added a commit
to I3oris/ic
that referenced
this pull request
Jun 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
glibc 2.34 has merged librt and libdl into libc, so they're not
available as shared libraries. The symbols are still available to the
interpreter because they are loaded in the compiler.
Fixes #12036