Fix Path#join to convert argument path to base kind
#12033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
added
kind:bug
This was referenced Apr 27, 2022
| end | ||
|
|
||
| new_instance new_name | ||
| parts.reduce(self) { |path, part| path.join(part) } |
There was a problem hiding this comment.
This will bring a little penalty to those that do not need conversion, since it will create an allocation per path. I don't know how important this difference might be though.
There was a problem hiding this comment.
We need correctness over performance. This can be optimized later, but it's not critical to optimize.
beta-ziliani
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the argument to
Path#joinis a different kind thanself(windows vs. posix path), the argument needs to be converted to the base kind. This did happen only for joining a windows path to a posix path, but not the other way around. This only became necessary with #11847. Previously, it would've been a no-op.This patch makes sure to always convert the parameter path when it doesn't match the base kind.
The PR is applied on top of #12032 which is required for the correct implementation of
Path#join(Enumerable)based onPath#join(String | Path).