Add pthread
link annotations in lib bindings
#12013
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In older versions of glibc (< 2.34),
pthread
is a separate library and needs to be explicitly added as linker argument.This implicitly works with programs that use the garbage collector, because a link annotation is added there to ensure proper link order:
crystal/src/gc/boehm.cr
Lines 16 to 17 in ef05e26
But when using
-Dgc_none
we were missing link annotations forpthread
since the cleanup in #11563This patch adds the missing annotation to the glibc bindings for
pthread
symbols. Other platforms might be affected as well (BSDs?), but it's only confirmed to be an issue for GNU so far.Resolves #11986