Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for Float, BigFloat rounding methods #12004

Merged
merged 1 commit into from
Apr 27, 2022
Merged

Add docs for Float, BigFloat rounding methods #12004

merged 1 commit into from
Apr 27, 2022

Conversation

marksiemers
Copy link
Contributor

These descriptions exist for BigDecimal - adding them for the float methods.

beta-ziliani
beta-ziliani approved these changes Apr 20, 2022
View reviewed changes
Copy link
Member

@beta-ziliani beta-ziliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@straight-shoota straight-shoota added this to the 1.5.0 milestone Apr 20, 2022
@marksiemers
Copy link
Contributor Author

Thanks for taking a look and being willing to accept the change.

Happy to see Crystal still going strong post 1.0!

@straight-shoota straight-shoota changed the title Add descriptions to Float & BigFloat rounding methods Add docs for Float, BigFloat rounding methods Apr 27, 2022
@straight-shoota straight-shoota merged commit 1d0ccf2 into crystal-lang:master Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beta-ziliani beta-ziliani beta-ziliani approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:docs kind:feature topic:stdlib:numeric
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@marksiemers @straight-shoota @beta-ziliani @Blacksmoke16 @MarkSiemers-msr