Use be_empty
expectations in more specs
#11937
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch replaces most usages of
empty?.should be_true
withshould be_empty
, andempty?.should be_false
withshould_not be_empty
, becausebe_empty
's failure message is more descriptive:The only exceptions are specs testing the
#empty?
method itself. Specs like these are preserved:crystal/spec/std/uri/params_spec.cr
Lines 299 to 305 in 458595f