Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support LLVM 14.0 #11905

Merged
merged 4 commits into from
Mar 26, 2022
Merged

Conversation

HertzDevil
Copy link
Contributor

@HertzDevil HertzDevil commented Mar 17, 2022

LLVM 14.0 final is scheduled to be released on March 15th (overdue). This PR contains minimal changes to get it working, due to https://reviews.llvm.org/D108614 and https://reviews.llvm.org/D116014.

@@ -19,6 +19,7 @@ end

{% begin %}
lib LibLLVM
IS_140 = {{LibLLVM::VERSION.starts_with?("14.0")}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also add IS_LT_140.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently there's no need for that, so why bother?

@HertzDevil HertzDevil marked this pull request as ready for review March 25, 2022 10:56
@@ -64,6 +64,9 @@ jobs:
- llvm_version: 13.0.0
llvm_url: https://github.com/llvm/llvm-project/releases/download/llvmorg-13.0.0/clang+llvm-13.0.0-x86_64-linux-gnu-ubuntu-20.04.tar.xz
base_image: ubuntu-20.04
- llvm_version: 14.0.0
llvm_url: https://github.com/llvm/llvm-project/releases/download/llvmorg-14.0.0/clang+llvm-14.0.0-x86_64-linux-gnu-ubuntu-18.04.tar.xz
base_image: ubuntu-18.04
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for using this old image?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's currently no ubuntu 20.04 image, so I'd guess it was the best choice?
https://github.com/llvm/llvm-project/releases/tag/llvmorg-14.0.0

@@ -19,6 +19,7 @@ end

{% begin %}
lib LibLLVM
IS_140 = {{LibLLVM::VERSION.starts_with?("14.0")}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently there's no need for that, so why bother?

Copy link
Member

@beta-ziliani beta-ziliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As always, thank you very much HertzDevil 🙇

@beta-ziliani beta-ziliani added this to the 1.4.0 milestone Mar 25, 2022
@straight-shoota straight-shoota merged commit d0fd9f6 into crystal-lang:master Mar 26, 2022
@HertzDevil HertzDevil deleted the feature/llvm-14 branch April 1, 2022 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants