-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support LLVM 14.0 #11905
Support LLVM 14.0 #11905
Conversation
@@ -19,6 +19,7 @@ end | |||
|
|||
{% begin %} | |||
lib LibLLVM | |||
IS_140 = {{LibLLVM::VERSION.starts_with?("14.0")}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd also add IS_LT_140
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently there's no need for that, so why bother?
@@ -64,6 +64,9 @@ jobs: | |||
- llvm_version: 13.0.0 | |||
llvm_url: https://github.com/llvm/llvm-project/releases/download/llvmorg-13.0.0/clang+llvm-13.0.0-x86_64-linux-gnu-ubuntu-20.04.tar.xz | |||
base_image: ubuntu-20.04 | |||
- llvm_version: 14.0.0 | |||
llvm_url: https://github.com/llvm/llvm-project/releases/download/llvmorg-14.0.0/clang+llvm-14.0.0-x86_64-linux-gnu-ubuntu-18.04.tar.xz | |||
base_image: ubuntu-18.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason for using this old image?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's currently no ubuntu 20.04 image, so I'd guess it was the best choice?
https://github.com/llvm/llvm-project/releases/tag/llvmorg-14.0.0
@@ -19,6 +19,7 @@ end | |||
|
|||
{% begin %} | |||
lib LibLLVM | |||
IS_140 = {{LibLLVM::VERSION.starts_with?("14.0")}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently there's no need for that, so why bother?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As always, thank you very much HertzDevil 🙇
LLVM 14.0 final is scheduled to be released on March 15th (overdue). This PR contains minimal changes to get it working, due to https://reviews.llvm.org/D108614 and https://reviews.llvm.org/D116014.