Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add File#chown and #chmod #11886

Merged
merged 17 commits into from
May 6, 2022
Merged

Add File#chown and #chmod #11886

merged 17 commits into from
May 6, 2022

Conversation

didactic-drunk
Copy link
Contributor

Described in #9192

straight-shoota
straight-shoota reviewed Mar 12, 2022
View reviewed changes
Copy link
Member

@straight-shoota straight-shoota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add cross-references between the docs for the new instance methods and the respective class methods?

src/crystal/system/win32/file.cr Outdated Show resolved Hide resolved
@didactic-drunk
Copy link
Contributor Author

Could you please add cross-references between the docs for the new instance methods and the respective class methods?

I'm not sure of the format you want. File.#info & File.#delete don't have cross references. Do you have an example?

@straight-shoota
Copy link
Member

Something like this maybe: 57bb5ae (#11881)

@didactic-drunk
Copy link
Contributor Author

MacOS broke, not my fault?

 error: file 'nixpkgs' was not found in the Nix search path (add it using $NIX_PATH or -I)

@didactic-drunk
Copy link
Contributor Author

1.5? Bump

@straight-shoota straight-shoota changed the title Add File#chown File#chmod Add File#chown and #chmod Apr 8, 2022
@didactic-drunk
Copy link
Contributor Author

I'm not sure how to do syscall feature detection in the last commit. Most systems support futimens except MacOS which only has futimes.

beta-ziliani
beta-ziliani reviewed May 2, 2022
View reviewed changes
Copy link
Member

@beta-ziliani beta-ziliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have one question, and if CI is ok, then nothing else 👌

src/file.cr Outdated Show resolved Hide resolved
@straight-shoota straight-shoota self-requested a review May 2, 2022 22:30
beta-ziliani
beta-ziliani approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@beta-ziliani beta-ziliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@beta-ziliani beta-ziliani added this to the 1.5.0 milestone May 5, 2022
@straight-shoota straight-shoota merged commit e7a2642 into crystal-lang:master May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sija Sija Sija left review comments

@beta-ziliani beta-ziliani beta-ziliani approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:feature topic:stdlib:files
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@didactic-drunk @straight-shoota @Sija @beta-ziliani @Blacksmoke16