Fix: Honour encoding in IO::Memory#to_s
#11875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
added
kind:bug
Sija
reviewed
Mar 7, 2022
| @@ -393,7 +393,11 @@ class IO::Memory < IO | |||
| # ``` | |||
| def to_s : String | |||
| if encoding = @encoding | |||
| String.new to_slice, encoding: encoding.name, invalid: encoding.invalid | |||
| {% if flag?(:without_iconv) %} | |||
| raise NotImplementedError.new("String.encode") | |||
There was a problem hiding this comment.
Wouldn't be better to move this check into the String.encode method instead?
There was a problem hiding this comment.
Yeah, I wondered about that. But String.encode is explicit about being for encoding purposes. Calling that method with -Dwithout_iconv should lead to a compile time error. IO::Memory#to_s on the other hand is not explicitly about encoding. It's just something that it needs to do in some state. In this case there should definitely not be a compile time error. So raising the runtime error here makes more sense IMO.
asterite
approved these changes
Mar 7, 2022
sdogruyol
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11015