Check file-private types for abstract defs and recursive structs #11838
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unimplemented abstract defs of file-private types do not trigger a compilation error until they are called:
Recursive value types do not trigger compilation errors at all:
This happens because both
Crystal::AbstractDefChecker
andCrystal::RecursiveStructChecker
only look at types reachable from the top-level namespace (i.e. theCrystal::Program
instance); this PR adds checks for the namespaces associated with each file-private scope.