Support tuple metaclass indexers with non-literal arguments #11834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sija
reviewed
Feb 16, 2022
asterite
reviewed
Feb 18, 2022
asterite
reviewed
Feb 18, 2022
This was referenced Apr 19, 2022
|
Thinking of #12005, to me the pattern FIELD = :field
tuple[FIELD]makes perfect sense; however, it won't work as expected since it will return the union of all the types of the tuple even if the value is known at compile time. How hard is it to consider this case specially? |
Very easy! But is there a reason to discuss this here instead of in #12005? |
|
No, it doesn't make sense for it to be here. (me to brain rn: GH comments are not a chat system GH comments are not a chat system GH comments are not a chat system ....) |
beta-ziliani
requested changes
May 2, 2022
beta-ziliani
approved these changes
May 3, 2022
…aclass-indexer-var
straight-shoota
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the following class methods:
Tuple.[](index : Int)Tuple.[]?(index : Int)NamedTuple.[](key : Symbol | String)NamedTuple.[]?(key : Symbol | String)They already work when the index is an integer literal, or when the key is a symbol or string literal. With this PR regular, non-literal variables also work.
Also "adds" a
Tuple.[](range : Range)overload which always fails to compile unlessrangeis a literal, similar to its non-metaclass counterpart.