-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IO#getb_to_end
#11830
Add IO#getb_to_end
#11830
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the #getb_to_end
override needs a call to check_open
.
I'm not sure, |
I mean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Maybe offtopic, but will there be other such methods...? For example getb
to get a line or up to a delimiter as Bytes
.
|
Resolves #11586. There is also an optimization for
IO::Memory
that skipsIO.copy
(a copy is still made so that changes to the IO don't affect the returnedBytes
).