Interpreter: support Tuple#[] with range literals
#11783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
approved these changes
Jan 29, 2022
asterite
reviewed
Jan 31, 2022
Comment on lines
+1426
to
+1429
| tuple_copy_element: { | ||
| operands: [tuple_size : Int32, old_offset : Int32, new_offset : Int32, element_size : Int32], | ||
| code: (stack - tuple_size + new_offset).copy_from(stack - tuple_size + old_offset, element_size), | ||
| }, |
There was a problem hiding this comment.
I wonder if it wouldn't make sense to define a copy_from instruction that doesn't advance the stack, or maybe as an argument to the existing copy_from. That way we don't keep adding instructions, and maybe we end up with a more general-purpose instruction. Totally optional, though!
asterite
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to compile (not run) most of the specs because
Specdepends on the methods insrc/humanize.crwhere this feature is used. I am not very satisfied with the way the indexer on non-metaclass tuples works, but the offset calculations are necessary because of alignment issues. Given:here we cannot simply move
a's last 5 bytes to the beginning, because there must be padding betweenb's two elements.