Remove useless assignments #11774
Merged
Remove useless assignments #11774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
approved these changes
Jan 27, 2022
src/mime/media_type.cr
Outdated
Comment on lines
450
to
451
| encoding, _split_one, rest = encoded.partition('\'') | ||
| _lang, _split_two, value = rest.partition('\'') |
There was a problem hiding this comment.
I think we can just use underscore without names to make the relevant variable names pop out more.
Suggested change
| encoding, _split_one, rest = encoded.partition('\'') | |
| _lang, _split_two, value = rest.partition('\'') | |
| encoding, _, rest = encoded.partition('\'') | |
| _, _, value = rest.partition('\'') |
Maybe keep _lang as a label, but I'd certainly toss out the separator names.
There was a problem hiding this comment.
_lang would still be unused. Does Ameba intentionally skip over variables starting with an underscore? (I know that Elixir does, for example.)
There was a problem hiding this comment.
Yes, I think the purpose of variable names with underscore prefix is to indicate that variable is unused, but still give it a label to document context.
There was a problem hiding this comment.
I fixed split word, and use the lang with the _ prefix, linter doesn't worry about this line now
straight-shoota
approved these changes
Jan 27, 2022
oprypin
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! this is my first
crystalcontribution. I ran the source code through the ameba analyzer (ttps://github.com/crystal-ameba/ameba) and fixed a few lines.If it's helpful I can correct others comments.
The pull request is in the draft stage, if anything needs to be fixed, I'd love some feedback.