Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parser error with semicolon + newline in parenthesized Expressions #11769

Merged
merged 2 commits into from
Jan 29, 2022
Merged

Fix parser error with semicolon + newline in parenthesized Expressions #11769

merged 2 commits into from
Jan 29, 2022

Conversation

straight-shoota
Copy link
Member

@straight-shoota straight-shoota commented Jan 25, 2022 •
edited
Loading

Re-issue of abandoned #11739

Minimal reproduction of the error:

(1; # Error: unexpected token: "NEWLINE"
2)

@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:parser labels Jan 25, 2022
@straight-shoota straight-shoota added this to the 1.4.0 milestone Jan 28, 2022
@straight-shoota straight-shoota merged commit 8d3155e into crystal-lang:master Jan 29, 2022
@straight-shoota straight-shoota deleted the fix-paren-exp-semicolon-newline branch January 29, 2022 21:04
@straight-shoota straight-shoota changed the title Fix parser error with semicolon + newline in parenthezied Expressions Fix parser error with semicolon + newline in parenthesized Expressions Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oprypin oprypin oprypin approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:parser
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@straight-shoota @oprypin