Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor etc/completion.bash #11719

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Refactor etc/completion.bash #11719

merged 1 commit into from
Feb 1, 2022

Conversation

HertzDevil
Copy link
Contributor

  • COMPREPLY is now always populated using one of the helper functions, to improve readability.
  • The autocompletion script now sets -o filenames only when necessary, to prevent commands from being interpreted as directories; for example, crystal <Tab> and crystal init <Tab> at the repository root would mistakenly return spec/ and lib/ respectively.
  • Filenames with spaces are now supported, by using the correct IFS.

beta-ziliani
beta-ziliani approved these changes Jan 28, 2022
View reviewed changes
Copy link
Member

@beta-ziliani beta-ziliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@beta-ziliani beta-ziliani added this to the 1.4.0 milestone Jan 28, 2022
@straight-shoota straight-shoota merged commit 8e93c99 into crystal-lang:master Feb 1, 2022
@HertzDevil HertzDevil deleted the refactor/bash-completion branch February 1, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beta-ziliani beta-ziliani beta-ziliani approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
topic:infrastructure
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@HertzDevil @straight-shoota @beta-ziliani