Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not inherit from Hash in the compiler #11707

Merged
merged 2 commits into from
Jan 21, 2022
Merged

Do not inherit from Hash in the compiler #11707

merged 2 commits into from
Jan 21, 2022

Conversation

HertzDevil
Copy link
Contributor

@HertzDevil HertzDevil commented Jan 6, 2022 •
edited
Loading

Crystal::HashStringType inherits from Hash(String, Type) and overrides only to_json. The same can be achieved with a converter, and JSON::Serializable properly handles the case where Crystal::ContextResult#contexts is nil.

I am honestly surprised the compiler didn't break before because of this.

@straight-shoota straight-shoota added this to the 1.4.0 milestone Jan 6, 2022
@straight-shoota straight-shoota merged commit b48f3a5 into crystal-lang:master Jan 21, 2022
@HertzDevil HertzDevil deleted the refactor/crystal-hashstringtype branch January 23, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

@asterite asterite asterite approved these changes

Assignees
No one assigned
Labels
kind:refactor topic:tools
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@HertzDevil @asterite @straight-shoota