Add docs for String#[]
#11690
Merged
Add docs for String#[]
#11690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HertzDevil
reviewed
Jan 4, 2022
src/string.cr
Outdated
| def []?(index : Int) : Char? | ||
| char_at(index) { nil } | ||
| end | ||
|
|
||
| def []?(str : String | Char) | ||
| # Returns the `String?` if the given *str* is in *self*. |
There was a problem hiding this comment.
Which String?? Ditto for below.
Also the code fails to compile for Char arguments due to the added return value restriction. It shouldn't be added.
There was a problem hiding this comment.
updated via dfcf6bc. I dont know but I think this solves the concern you have.
yxhuvud
reviewed
Jan 4, 2022
Co-authored-by: Johannes Müller <[email protected]>
Co-authored-by: Johannes Müller <[email protected]>
Co-authored-by: Johannes Müller <[email protected]>
Co-authored-by: Johannes Müller <[email protected]>
Co-authored-by: Johannes Müller <[email protected]>
Fryguy
reviewed
Jan 4, 2022
Co-authored-by: Jason Frey <[email protected]>
oprypin
approved these changes
Jan 27, 2022
Co-authored-by: Oleh Prypin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.