Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix no comma before short block in ToSVisitor #11677

Merged
merged 2 commits into from
Jan 3, 2022
Merged

Fix no comma before short block in ToSVisitor #11677

merged 2 commits into from
Jan 3, 2022

Conversation

homonoidian
Copy link
Contributor

Closes #11674.

@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:parser labels Jan 1, 2022
@straight-shoota
Copy link
Member

Can you please add a spec to to_s_spec.cr?

@oprypin oprypin self-requested a review January 1, 2022 19:04
@straight-shoota straight-shoota added this to the 1.3.0 milestone Jan 1, 2022
@straight-shoota straight-shoota merged commit 62e459f into crystal-lang:master Jan 3, 2022
rdp pushed a commit to rdp/crystal that referenced this pull request Jan 19, 2022
@homonoidian @rdp
Fix no comma before short block in ToSVisitor (crystal-lang#11677)
5af7264
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

@oprypin oprypin oprypin approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:parser
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

No comma before short block in a named-arg-only call after macro expansion
3 participants
@homonoidian @straight-shoota @oprypin