Fix Array#unshift
for large arrays
#11656
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#unshift
still assumes the new capacity is exactly twice the old one whenever a reallocation is needed, which is no longer true for large arrays after #11482, so everything past around the firstnew_capacity / 2
elements would be referring to invalid storage, leading to potential heap corruption:Pushes will also no longer reallocate:
This PR fixes it.