Format spec results with pretty inspect #11635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with Object.pretty_inspect to facilitate formatting of classes and structs in the displayed results after running a spec test suite.
… with Object.pretty_inspect to facilitate formatting of classes and structs in the displayed results after running a spec test suite.
straight-shoota
approved these changes
Feb 22, 2022
beta-ziliani
approved these changes
Dec 20, 2022
|
@beta-ziliani Actually, I'd rather postpone this to 1.8. The idea was to merge this in advance of a release so we have time to observe the effects. |
|
We're nearing the 1.8 release, so I'm just checking back on this. Nobody has complained about the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing all instances of Object.inspect with Object.pretty_inspect in the /src/spec/expectations.cr file for better readability of classes and structs in spec test results.
https://forum.crystal-lang.org/t/formatting-spec-test-results/4129/3