Workaround for GC issues in interpreter specs #11634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
added
kind:bug
straight-shoota
force-pushed
the
feature/i-integration-specs
branch
from
84a76f3 to
137e692
Compare
beta-ziliani
approved these changes
Dec 30, 2021
| end | ||
|
|
||
| def interpret_with_context(code, *, prelude = "primitives") | ||
| def interpret_with_context(code, prelude = "primitives") |
There was a problem hiding this comment.
Wouldn't it make sense to make this one private to avoid shooting ourselves in the foot?
There was a problem hiding this comment.
We can't make this helper private, because it's used in specs when it needs access to the context, instead of just the value.
But I suppose we can remove the prelude parameter to fix it to "primitives".
|
I think we should merge this re-enabling CI, explicitly stating that it reverses #11623. I think a specific revert to it adds some bureaucracy without any real gain. |
Co-authored-by: Beta Ziliani <[email protected]>
|
Nice, thanks! |
rdp
pushed a commit
to rdp/crystal
that referenced
this pull request
Jan 19, 2022
Co-authored-by: Beta Ziliani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch prevents the GC issues in interpeter specs (#11580) as suggested as second option in #11602
The implementation hooks into
Specs option parser in order to add an alternative operation mode for the spec executable which works as an interpreter implementation that meets the specific needs of spec execution. This is a bit dirty, but I think it's acceptable as a temporary solution. It's definitely the fastest solution because it doesn't require an extra compiler build (neither explicitly nor implicitly). Everything necessary is already available in the spec executable, it just needs a way to expose that so it can be called externally.Now the interpreter specs execute in 2:22 minutes (on my machine) and takes about 3.3 GB of memory. Previously, it took forever and claimed all the memory 😈
With this change (
and #11624merged by now), thetest_interpreterjob in CI should succeed again. I'm merging that and enabling CI in this branch to verify that. But it doesn't need to be merged with it. #11624 should obviously be merged on its own. I don't see a reason to delay enabling CI, but we might want to merge an explicit revert of #11623.Resolves #11602
Reverts #11623