Revert "Formatter: Escape non-printable characters in literals" #11603
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #11520
This change broke the format of
grapheme_spec
which was merged in #11472 in the mean time: https://github.com/crystal-lang/crystal/runs/4554342641?check_suite_focus=truegrapheme_spec
has string literals with graphemes containing non-printable characters. The formatter produces this diff (I isolated and reorderd the lines for better readability):I think that's a legitimate use case for non-printable characters in string literals. Thus we should revert #11520.
We can reconsider whether we want to improve this feature and add it again or drop it.