Use enum instead of symbol for Atomic primitives
#11583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oprypin
reviewed
Dec 15, 2021
Sija
reviewed
Dec 17, 2021
| @@ -0,0 +1,27 @@ | |||
| module LLVM | |||
There was a problem hiding this comment.
Is there any reason for extracting this particular set of enums, and not the others?
There was a problem hiding this comment.
This is a partial refactor, including only the enums associated with atomic.
beta-ziliani
reviewed
May 2, 2022
beta-ziliani
approved these changes
May 2, 2022
| @@ -0,0 +1,27 @@ | |||
| module LLVM | |||
There was a problem hiding this comment.
This is a partial refactor, including only the enums associated with atomic.
straight-shoota
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the LLVM enums to the standard library (as
:nodoc:types) and relies on autocasting to transport the correct values to code generation. The casing of the enum members is important;:umaxdoesn't autocast toUMax, onlyUmax.Out of caution, support for symbol parameters / arguments is still there and would be removed after 1.3.0; afterwards, we can use the enums directly without autocasting if we want (it seems the interpreter code might benefit from this).
Atomic::Opsis not a public API so this shouldn't be considered a breaking change.