-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Int128
in codegen and macros
#11576
Merged
straight-shoota
merged 12 commits into
crystal-lang:master
from
BlobCodes:feature/codegen-int128-inline-support
Jan 29, 2022
Merged
Add support for Int128
in codegen and macros
#11576
straight-shoota
merged 12 commits into
crystal-lang:master
from
BlobCodes:feature/codegen-int128-inline-support
Jan 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Seems like the only failing specs currently are in the interpreter due to a missing |
straight-shoota
approved these changes
Jan 25, 2022
oprypin
approved these changes
Jan 27, 2022
straight-shoota
changed the title
Add codegen int128 support
Add support for Jan 29, 2022
Int128
in codegen and macros
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
Things that still need to be addressed:
to_i
method always converts a string to a int64, and then casts it to a int32. integers greater than Int64::MAX return an error "(number) is not an integer", while integers greater than Int32::MAX but smaller than or equal Int64::MAX return an error "Invalid Int32: (number).Probably requires #11551 to pass compiler specs on windows.