Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable kernel_spec.cr on Windows CI #11554

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

HertzDevil
Copy link
Contributor

Enables specs for ::#exit and ::#at_exit. The segmentation fault (access violation) specs are now pending.

This isn't the best place to test for system-dependent newlines, so puts calls within those specs are replaced with print.

@HertzDevil HertzDevil added kind:specs platform:windows Windows support based on the MSVC toolchain / Win32 API topic:stdlib:system labels Dec 8, 2021
@straight-shoota straight-shoota added this to the 1.3.0 milestone Dec 8, 2021
@straight-shoota straight-shoota merged commit eeef471 into crystal-lang:master Dec 9, 2021
@HertzDevil HertzDevil deleted the spec/kernel-spec branch December 10, 2021 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:specs platform:windows Windows support based on the MSVC toolchain / Win32 API topic:stdlib:system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants