Refactor some type restrictions in the compiler #11531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
commented
Dec 2, 2021
| if type.is_a?(GenericInstanceType) | ||
| type.generic_type | ||
| type.generic_type.as(Type) |
There was a problem hiding this comment.
GenericInstanceType#generic_type returns GenericType hence the resulting type would be a union GenericType | Type. All including types of GenericType inherit from Type but the compiler doesn't merge this union.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch applies a couple small refactorings that remove unintended type unions. In the case of
Annotatableit restricts the interface to allow only meaningful types.