-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict identifier grammar #11508
Restrict identifier grammar #11508
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one little concern, the rest is 👌
From discord, someone may have a found a regression: :▲ # => Error: unexpected token: ":"
pp :▲ # => Error: unknown token: '▲' I'm assuming this is what was meant by #11216, but wanted to at least report it to be sure. |
Symbol literals should accept a larger grammar than identifiers, since they already allow things like |
I suppose, for symbols we can probably use |
However, |
This reverts commit 1653cf3.
This patch restricts the grammar for identifiers to the suggested class Default Identifiers from UAX #31 (revision 35).
Also adds character data for the Unicode general category
Pc
and a couple of nodoc methods for querying specific Unicode categories.Resolves #11216