Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Char#letter? to include all letter categories #11474

Merged
merged 1 commit into from
Nov 19, 2021
Merged

Fix Char#letter? to include all letter categories #11474

merged 1 commit into from
Nov 19, 2021

Conversation

straight-shoota
Copy link
Member

There are five Unicode General Categories for letters: Lu, Ll, Lt, Lm and Lo. Codepoints in the latter two are not recognized by Char#letter?.

With this patch this is fixed:

# Unicode General Category Lm
'ʰ'.letter?  # => true 
# Unicode General Category Lo
'か'.letter? # => true

@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:text labels Nov 18, 2021
@straight-shoota straight-shoota added this to the 1.3.0 milestone Nov 18, 2021
@straight-shoota straight-shoota merged commit 4204bce into crystal-lang:master Nov 19, 2021
@straight-shoota straight-shoota deleted the fix/unicode-letter branch November 19, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oprypin oprypin oprypin approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:text
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@straight-shoota @oprypin