Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor some target flag uses #11466

Merged

Conversation

straight-shoota
Copy link
Member

This patch improves some macro flag uses.

  • Use skip_file instead of wrapping the entire content in a conditional
  • Use generalized flags for arch size (bits32 and bits64) instead of specific architectures
  • Use if flag?(:unix) instead of unless flag?(:win32) for platform-specific opt-in

@straight-shoota straight-shoota added this to the 1.3.0 milestone Nov 18, 2021
@straight-shoota straight-shoota merged commit 59f648e into crystal-lang:master Nov 22, 2021
@straight-shoota straight-shoota deleted the refactor/target-flags branch November 22, 2021 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants