-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support call stacks on Windows #11461
Merged
straight-shoota
merged 7 commits into
crystal-lang:master
from
HertzDevil:feature/msvc-call-stack
Nov 24, 2021
Merged
Support call stacks on Windows #11461
straight-shoota
merged 7 commits into
crystal-lang:master
from
HertzDevil:feature/msvc-call-stack
Nov 24, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HertzDevil
added
kind:feature
platform:windows
Windows support based on the MSVC toolchain / Win32 API
topic:stdlib:runtime
labels
Nov 16, 2021
straight-shoota
approved these changes
Nov 16, 2021
22 tasks
Sija
reviewed
Nov 17, 2021
Sija
reviewed
Nov 17, 2021
oprypin
reviewed
Nov 21, 2021
oprypin
approved these changes
Nov 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind:feature
platform:windows
Windows support based on the MSVC toolchain / Win32 API
topic:stdlib:runtime
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10612. Some of the code is taken from there, some other from JochenKalmbach/StackWalker.
StackWalk64
API. Column numbers are omitted because DbgHelp doesn't seem to expose it, short of parsing the PDB ourselves (apparently it is also problematic for most Windows tools, including the Visual Studio debugger).--no-debug
is specified. Also no longer emits DWARF debug information on Windows.CRYSTAL_LOAD_DWARF
toCRYSTAL_LOAD_DEBUG_INFO
to be platform-independent.Note that this doesn't catch access violation (0xC0000005) and stack overflow (0xC00000FD) yet.
Related: #5430