Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pcre download URL #11422

Merged

Conversation

straight-shoota
Copy link
Member

The server at ftp://ftp.pcre.org has been shut down. This patch changes to a different mirror for downloading libpcre.

This is the equivalent to crystal-lang/distribution-scripts#166 for our windows CI.

@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:infrastructure labels Nov 9, 2021
Copy link
Member

@matiasgarciaisaia matiasgarciaisaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're downloading the files from an unofficial mirror, we may want to check the file's signature - or at least check the downloaded file's hash so we know it hasn't changed.

It's a nice practice anyway, even from the official mirror.

@straight-shoota
Copy link
Member Author

Definitely! Let's make that a separate task, though.

@straight-shoota straight-shoota merged commit 71bdd14 into crystal-lang:master Nov 9, 2021
@straight-shoota straight-shoota deleted the fix/pcre-download branch November 9, 2021 18:38
straight-shoota added a commit that referenced this pull request Nov 9, 2021
@straight-shoota straight-shoota added this to the 1.2.2 milestone Nov 9, 2021
straight-shoota added a commit to straight-shoota/crystal that referenced this pull request Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants