[Makefile] Add format target #11420
Merged
[Makefile] Add format target #11420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HertzDevil
reviewed
Aug 13, 2022
HertzDevil
approved these changes
Aug 14, 2022
Sija
reviewed
Aug 14, 2022
| @@ -25,6 +25,7 @@ verbose ?= ## Run specs in verbose mode | |||
| junit_output ?= ## Path to output junit results | |||
| static ?= ## Enable static linking | |||
| interpreter ?= ## Enable interpreter feature | |||
| check ?= ## Enable only check when running format | |||
There was a problem hiding this comment.
I'd use some more explicit name here, like:
Suggested change
| check ?= ## Enable only check when running format | |
| formatter_check ?= ## Enable only check when running format |
There was a problem hiding this comment.
Na, that's just redundant. This flag only has a meaning for the format recipe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a
formattarget to the Makefile. I've had this in my local Makefile for a while. I think it's useful to format code locally and having it applied to the correct locations. For example, we don't want to format the files in./libwhich are vendored in via git subtree.We can already make use of the recipe in
bin/ci format.