Replace lib version comparisons by functional feature checks #11374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to check the library version at the binding definition and call site again. Checking the availability of lib methods is easier and enables cross-library usability (libressl and openssl define the same functions). This also fixes differences in the API of SSL::Context depending on the library version. Stdlib APIs must be consistent. Some methods that were missing when linking against older library versions now raise NotImplementedError at runtime.
straight-shoota
added
kind:bug
oprypin
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to check the library version at the binding definition and call site again. Checking the availability of lib methods is easier and enables cross-library usability (libressl and openssl define the same functions).
This also fixes differences in the API of SSL::Context depending on the library version. Stdlib APIs must be consistent. Some methods that were missing when linking against older library versions now raise NotImplementedError at runtime.