Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
BitArray#reverse!
available throughIndexable::Mutable
, this PR adds a much more performant implementation through the addition of thellvm.bitreverse.*
intrinsics. These intrinsics are available in all LLVM releases supported by Crystal (latest down to 3.8).On large
BitArray
s, this new implementation is ~20x faster for sizes that are multiples of 32, ~13x faster for sizes that aren't. On smallBitArray
s this becomes a constant-time operation. Benchmarks: