Add Comparison operator to UUID #11352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UUIDs are comparable according to RFC 4122. This implements the comparison according to the spec.
HertzDevil
reviewed
Oct 24, 2021
|
I would point out that if StaticArray is gonna end up being comparable, this can be cleaned up even more by comparing the arrays. |
straight-shoota
approved these changes
Oct 25, 2021
oprypin
approved these changes
Oct 25, 2021
|
I dont see the comparable part in the RFC. What section is it in? |
|
A use case is described in #11023 (comment) |
|
|
Implementations section page 24 has a code example of UUID compare |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to RFC 4122, UUIDs are comparable. This implements the spaceship operator on UUIDs according to the specification.
Implements #11023