Attach debug locations to auto-generated initialize methods
#11313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HertzDevil
added
kind:bug
straight-shoota
approved these changes
Oct 14, 2021
oprypin
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a type has no constructors at all, then the compiler automatically generates the
.newand#initializemethods. The former is attached to the first declaration of the type, but the latter isn't; this PR gives it the same treatment.In particular,
Reference#initializeused to have no locations, and this caused the auto-generated constructors for generic classes to lose theirs too:This shows up on Compiler Explorer as the constructors of
Thread::LinkedList(T)were never considered library code. They are now filtered after this patch.