Fix WebSocket#stream flushing for not exactly buffer size, add specs
#11299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StreamIO#flush was incorrectly sending data from the insertion position until the end of the buffer, instead of from the start of the buffer up until the position. The existing tests did not catch this because they were sending 1.5x buffer size of the same character, and so when it did the second flush, the position happened to have the exact number of bytes left and they were already set with that character from the first time around. This patch fixes the problem, and adds a test for streaming less than one buffer size. It also adds a few end-to-end websocket integration tests to cover several different situations to hopefully prevent regressions in the future.
straight-shoota
approved these changes
Oct 9, 2021
straight-shoota
added
kind:bug
oprypin
changed the title
oprypin
approved these changes
Oct 26, 2021
@oprypin I think it's a problem for any stream that is not exactly a multiple of the buffer size. Like if you send today 1.2x a buffer size, you get the last 80% of the first buffer appended to the end of the second flush. But it's been a few days now and all of this has fallen out of my head completely, so I'm not sure. |
sdogruyol
approved these changes
Nov 26, 2021
straight-shoota
changed the title
straight-shoota
changed the title
WebSocket#stream flushing for not exactly buffer size, add specs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StreamIO#flush was incorrectly sending data from the insertion position
until the end of the buffer, instead of from the start of the buffer up
until the position.
The existing tests did not catch this because they were sending 1.5x
buffer size of the same character, and so when it did the second flush,
the position happened to have the exact number of bytes left and they
were already set with that character from the first time around.
This patch fixes the problem, and adds a test for streaming less than
one buffer size.
It also adds a few end-to-end websocket integration tests to cover
several different situations to hopefully prevent regressions in the
future.
Fixes #11296