[CI] Sanitize version from branch name #11294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
added
kind:bug
beta-ziliani
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For maintenance builds, the Crystal version is derived from the branch name. But some characters we typically use in branch names are not valid in some places where the version value is used.
There had already been some sanitizing (replace
/by-and strip leadingrelease/). This patch adds replacing_by-. The latter has caused issues in crystal-lang/distribution-scripts#143 (comment) and the succeeding workflow https://app.circleci.com/pipelines/github/crystal-lang/crystal/6981/workflows/94c27061-f6c0-4e12-b58b-252c9a03c39d shows that the change was successful.