Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parser to never create doc from trailing comment #11268

Merged
merged 5 commits into from
Sep 17, 2022
Merged

Fix parser to never create doc from trailing comment #11268

merged 5 commits into from
Sep 17, 2022

Conversation

straight-shoota
Copy link
Member

Resolves #11249

@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:parser labels Oct 1, 2021
@straight-shoota straight-shoota mentioned this pull request Oct 23, 2021
Merged
@oprypin oprypin requested a review from HertzDevil November 12, 2021 23:23
@oprypin oprypin requested a review from asterite December 4, 2021 10:13
HertzDevil
HertzDevil approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@HertzDevil HertzDevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With @comment_is_doc I think we could also reject the shebang from being a doc comment. Not necessary here though.

@straight-shoota straight-shoota added this to the 1.6.0 milestone Sep 9, 2022
@straight-shoota straight-shoota merged commit d8d3a0f into crystal-lang:master Sep 17, 2022
@straight-shoota straight-shoota deleted the fix/parser-trailing-comment-doc branch September 17, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HertzDevil HertzDevil HertzDevil approved these changes

@asterite asterite Awaiting requested review from asterite

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:parser
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

inline doc comments for enum values are incorrectly associated with line below
2 participants
@straight-shoota @HertzDevil