Regex: use PCRE_UCP
#11265
Merged
Regex: use PCRE_UCP
#11265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
added
kind:bug
straight-shoota
approved these changes
Oct 1, 2021
|
I'm fine with this change if it works. But according to #4704 (comment) it might not work depending on the compile config of the linked libpcre. |
|
It works for me and I'm on mac. That comment mentions it doesn't work for mac, so I don't know 🤷 CI is green too. |
|
It was a couple of years ago, maybe it has changed since then 👍 |
|
Should we add a spec for the sample in #4704 as well? |
|
Done! |
sdogruyol
approved these changes
Oct 1, 2021
|
Let's merge it for 1.3 and see if there are any issues with the nightly builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11262
Fixes #4704
See https://www.pcre.org/original/doc/html/pcre_compile.html (search for PCRE_UCP.) It doesn't mention
[:print:]but I assume it applies to that as well, because with this it starts working fine.