Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unicode: update to version 14.0.0 #11215

Merged
merged 2 commits into from
Sep 21, 2021
Merged

Unicode: update to version 14.0.0 #11215

merged 2 commits into from
Sep 21, 2021

Conversation

Blacksmoke16
Copy link
Member

@HertzDevil
Copy link
Contributor

I think we should also declare the latest supported Unicode version in a constant like Unicode::VERSION = "14.0.0". Then specs and scripts could refer to it (e.g. #10721).

sdogruyol
sdogruyol approved these changes Sep 19, 2021
View reviewed changes
Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Blacksmoke16 🙏

@straight-shoota straight-shoota added this to the 1.2.0 milestone Sep 19, 2021
@straight-shoota straight-shoota merged commit 37268a0 into crystal-lang:master Sep 21, 2021
@Blacksmoke16 Blacksmoke16 deleted the unicode-14 branch September 21, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdogruyol sdogruyol sdogruyol approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

@jhass jhass jhass approved these changes

Assignees
No one assigned
Labels
kind:feature topic:stdlib:text
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Blacksmoke16 @HertzDevil @jhass @straight-shoota @sdogruyol