Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a few related optimizations:
n = 0
or a multiple ofsize
in the defaultIndexable::Mutable
implementation skips the loop altogether.Array#rotate!
toSlice
, so that anySlice
-based container could leverage it. This includesBitArray
(only whenn
andsize
are both multiples of 8, i.e. the rotation can be done on byte boundaries), andStaticArray
.BitArray
s when rotating 32 or fewer elements in either direction. It uses integer shifts and continues taking O(1) space, so it is very fast compared to the default algorithm. Benchmarks: