CSV: don't eagerly check next char after newline #11174
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11172
When a
\n
char was detected by the lexer, it would check what the next char was. If it was\0
it means the end of the file/stream as opposed to a newline. However, doing this when streaming over an IO meant that the newline token wasn't returned until more content was available after the newline. This isn't ideal.This PR changes that so that we only check the content after the newline if a next token is asked. This allows the parser to produce a row right after a newline comes.
This is technically a breaking change because something like "a\n" would previously produce
Cell("a"), EOF
but now it will produceCell("a"), Newline, EOF
. I think this breaking change is acceptable because: