Refactor sort methods to #sort and #unstable_sort
#11029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
force-pushed
the
refactor/unstable_sort
branch
from
80ec917 to
1b79cef
Compare
straight-shoota
force-pushed
the
refactor/unstable_sort
branch
from
1b79cef to
fe2564a
Compare
|
@straight-shoota Typo in PR description: Having an unstable search would be an interesting design choice for sure 😉 |
|
Haha, thanks for pointing out. I had a really weird feeling while putting that down, but was apparently to blind to recognize what's wrong. |
sdogruyol
approved these changes
Aug 2, 2021
straight-shoota
changed the title
#sort and #unstable_sort#sort and #unstable_sort
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up on #10163 refactoring the search API from a single method with a parameter for choosing stability to different methods
#sortand#unstable_sort(see #6057 (comment)).sort(stable: true)=>sortsort(stable: false)=>unstable_sortProper API documentation is still missing, but I'd like to solve that with a
Sortablemodule. That might still need some ironing out. This first iteration is just for settling down the API.