Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing required args for Socket::Addrinfo::Error.new #10960

Merged
merged 1 commit into from
Jul 20, 2021
Merged

Fix missing required args for Socket::Addrinfo::Error.new #10960

merged 1 commit into from
Jul 20, 2021

Conversation

straight-shoota
Copy link
Member

@straight-shoota straight-shoota commented Jul 18, 2021 •
edited
Loading

Resolves #10958

Fixes a regression introduced in #10761

@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:networking kind:regression Something that used to correctly work but no longer works labels Jul 18, 2021
@straight-shoota straight-shoota mentioned this pull request Jul 19, 2021
Merged
@straight-shoota straight-shoota added this to the 1.2.0 milestone Jul 19, 2021
@Sija
Copy link
Contributor

Sija commented Jul 19, 2021

@straight-shoota title is wrong, it should mention Socket::Addrinfo::Error.new instead of ArgumentError.new.

@straight-shoota straight-shoota changed the title Fix missing required named args for ArgumentError.new overload Fix missing required named args for Socket::Addrinfo::Error.new overload Jul 20, 2021
@straight-shoota straight-shoota changed the title Fix missing required named args for Socket::Addrinfo::Error.new overload Fix missing required args for Socket::Addrinfo::Error.new Jul 20, 2021
@straight-shoota straight-shoota merged commit 0fae69d into crystal-lang:master Jul 20, 2021
@straight-shoota straight-shoota deleted the fix/addrinfo-error-initialize branch July 20, 2021 11:05
@straight-shoota straight-shoota modified the milestones: 1.2.0, 1.1.1 Jul 20, 2021
@straight-shoota straight-shoota mentioned this pull request Jul 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcardiff bcardiff bcardiff approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. kind:regression Something that used to correctly work but no longer works topic:stdlib:networking
Projects
None yet
Milestone
1.1.1
Development

Successfully merging this pull request may close these issues.

Socket::Addrinfo::Error.new No Longer Works in 1.1.0
3 participants
@straight-shoota @Sija @bcardiff