Don't emit debug info for unused variable declarations #10957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
approved these changes
Jul 17, 2021
straight-shoota
added
kind:bug
asterite
reviewed
Jul 17, 2021
| llvm_var = context.vars[name] | ||
| # If a variable is deduced to have type `NoReturn` it might not be | ||
| # allocated at all | ||
| next unless (llvm_var = context.vars[name]?) |
There was a problem hiding this comment.
This is totally optional, but I prefer the assignment and the condition to be split. Then the comment is only relevant to the condition, not the assignment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6919. Fixes #9882.
More specifically, given:
x : Int32Its type is deduced to be
NoReturnafter semantic analysis is completed, because it is never used; conversely, if any variable isNoReturn, then no assignments to it are possible, so it must also be unused, e.g.:NoReturnvariables never allocate stack space during code generation. ThusNoReturnor unused variables in a semantic context will not appear in its corresponding codegen context. This PR makes sure to ignore those variables.