Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix self in restrictions when instantiating macro def in subtypes #10954

Merged

Conversation

HertzDevil
Copy link
Contributor

@HertzDevil HertzDevil commented Jul 16, 2021

Fixes #5044. See #5044 (comment) for the details.

Does not affect #7105 (which copies the incorrect defs into subtypes).

@HertzDevil HertzDevil changed the title Fix self's type when macro def is about to be instantiated in subtypes Fix self in restrictions when instantiating macro def in subtypes Jul 16, 2021
@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:semantic labels Jul 16, 2021
@straight-shoota straight-shoota added this to the 1.6.0 milestone Aug 13, 2022
@straight-shoota straight-shoota merged commit a2d05e4 into crystal-lang:master Aug 14, 2022
@HertzDevil HertzDevil deleted the bug/macro-def-virtual-self branch August 14, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:semantic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comparing union of sub-structs affects comparison of other structs
2 participants