Fix Enumerable#each
block return type
#10928
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The block's return type restriction should be empty instead of underscore (see #10467 (comment)). There's an unintended subtle difference for yielding blocks and underscore may break perfectly valid code (https://app.circleci.com/pipelines/github/straight-shoota/crinja/743/workflows/6a3278a5-8635-417a-96b5-ff7a483ae983/jobs/1307).
The block return type on
Enumerable#each
itself isn't really important because the block param type restriction is pretty much ignored for abstract defs (see #10902). But the type restriction onIterator#each
matters./cc #10905 (comment)