Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Enumerable#tally_by #10922

Merged
merged 3 commits into from
Aug 23, 2021
Merged

Implement Enumerable#tally_by #10922

merged 3 commits into from
Aug 23, 2021

Conversation

caspiano
Copy link
Contributor

Resolves #10921

@caspiano
Copy link
Contributor Author

caspiano commented Jul 12, 2021 •
edited
Loading

Updated to Enumerable#tally_by(& : T -> U) : Hash(U, Int32) forall U based on suggestions by @asterite and @HertzDevil here #10921 (comment)

@caspiano caspiano changed the title Implement Enumerable#tally with a block Implement Enumerable#tally_by Jul 12, 2021
sdogruyol
sdogruyol approved these changes Aug 14, 2021
View reviewed changes
Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @caspiano 🙏

@straight-shoota straight-shoota added this to the 1.2.0 milestone Aug 14, 2021
@straight-shoota straight-shoota merged commit c97946b into crystal-lang:master Aug 23, 2021
@caspiano caspiano deleted the feat/tally-with-block branch August 24, 2021 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdogruyol sdogruyol sdogruyol approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:feature topic:stdlib:collection
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

Allow Enumerable#tally to accept a block
3 participants
@caspiano @straight-shoota @sdogruyol