Limit the number of rendered overloads on signature mismatch #10890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sija
reviewed
Jul 3, 2021
Co-authored-by: Sijawusz Pur Rahnama <[email protected]>
|
I don't think this prevents |
|
@HertzDevil good point. I'm just wrapping my head around the matching code and then I will update this PR |
lbguilherme
reviewed
Jul 4, 2021
|
@HertzDevil looks like these changes fix the issue. I think a little bit more of an involved refactor would be required for failing before exhausting the The output of OP's example against these changes can be found here |
beta-ziliani
approved these changes
Mar 2, 2022
straight-shoota
approved these changes
Mar 2, 2022
straight-shoota
added
kind:bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9880
Looking for feedback on a sane limit to the number of rendered overloads 👀